headlessui

Files

T

Robin Malfait b59c091030 Fix broken escape key behaviour (#754 )

* fix broken `escape` key behaviour

We've "fixed" an issue when we had nested Dialogs ([#430](https://github.com/tailwindlabs/headlessui/pull/430)).
The `escape` would not close the correct Dialog. The issue here was with
the logic to know whether we were the last Dialog or not. The issue was
_not_ how we implemented the `close` functionality.

To make things easier, we moved the global window event to a scoped div
(the Dialog itself). While that fixed the nested Dialog issue, it
introduced this bug where `escape` would not close if you click on a
non-focusable element like a span in the Dialog.

Since that PR we did a bunch of improvements on how the underlying
"stacking" system worked.
This PR reverts to the "global" window event listener so that we can
still catch all of the `escape` keydown events.

Fixes: #524
Fixes: #693

* update changelog

2021-08-24 11:26:19 +02:00

components

Fix broken escape key behaviour (#754 )

2021-08-24 11:26:19 +02:00

hooks

Only add type=button for real buttons (#709 )

2021-08-02 13:57:58 +02:00

internal

Ensure that you can use Transition Child components in more scenario's (#503 )

2021-05-10 18:36:49 +02:00

test-utils

Only add type=button for real buttons (#709 )