Files
headlessui/packages/@headlessui-react/src/components/combobox
Robin Malfait 07c3a61b5c Improve some internal code (#1221)
* remove raw `document.getElementById` calls

When we introduced the `forwardRef` for all components, we also made
sure that internal `ref`s were used to keep track of the actual DOM
node.

This code prefers the `internalXXRef` refs in favor of the
`document.getElementById` calls. This is way more React-ish, and also
fixes a few issues:

- Potential performance improvements (no need to re-query the DOM, since
  we already have a reference to the DOM node). Note: this is a *guess*,
  I didn't measure this.
- It could be that the element is rendered in another `document`, the
  correct would involve something like
  `someDOMNode.ownerDocument.getElementById(...)` but that should not be
  necessary anymore now.

* make Disclosure implementation between React & Vue consistent

* use a similar convention for DOM refs to other components

* update changelog
2022-03-09 17:48:08 +01:00
..