Commit Graph

2 Commits

Author SHA1 Message Date
Robin Malfait 74c987351f ensure cb in useOnUnmount is a stable reference 2023-04-26 14:56:06 +02:00
Muhammad Ilham Mubarak 5cfbb4b5e5 Ensure FocusTrap is only active when the given enabled value is true (#2456)
* fix(tabs): wrong tab focus when Tab contains a Dialog

* refactor(focus-trap): rename variable and move logic

* test(tabs): improve test by asserting the active element

* ensure `FocusTrap` is not active when `enabled = false`

* fix: move the enabled check to unmounting

* refactor to `useOnUnmount` hook

This will allow us to make the code relatively similar between React and
Vue.

* update changelog

---------

Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
2023-04-26 14:51:01 +02:00