From a3fa86b6f49347aeba20a5938b4150a3fc918b2a Mon Sep 17 00:00:00 2001 From: Robin Malfait Date: Wed, 2 Aug 2023 13:43:28 +0200 Subject: [PATCH] only check if `_mainTreeNodeRef` is passed in It can be that it is passed in but still `null`, that's fine because it means it will be passed in later once the DOM is ready. --- .../src/hooks/use-root-containers.tsx | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/@headlessui-react/src/hooks/use-root-containers.tsx b/packages/@headlessui-react/src/hooks/use-root-containers.tsx index 1085980..e3b8d34 100644 --- a/packages/@headlessui-react/src/hooks/use-root-containers.tsx +++ b/packages/@headlessui-react/src/hooks/use-root-containers.tsx @@ -1,6 +1,5 @@ import React, { useRef, useMemo, MutableRefObject } from 'react' import { Hidden, Features as HiddenFeatures } from '../internal/hidden' -import { useComputed } from './use-computed' import { useEvent } from './use-event' import { useOwnerDocument } from './use-owner' @@ -60,15 +59,10 @@ export function useRootContainers({ mainTreeNodeRef, MainTreeNode: useMemo(() => { return function MainTreeNode() { - let hasPassedInMainTreeNode = useComputed( - () => (_mainTreeNodeRef?.current ?? null) !== null, - [_mainTreeNodeRef] - ) - if (hasPassedInMainTreeNode) return null - + if (_mainTreeNodeRef != null) return null return } - }, [mainTreeNodeRef]), + }, [mainTreeNodeRef, _mainTreeNodeRef]), } }