From 96e0fa96bd471c034deffeb63e28cc15580c220e Mon Sep 17 00:00:00 2001 From: Robin Malfait Date: Mon, 30 Nov 2020 12:35:53 +0100 Subject: [PATCH] remove unused d dependency --- .../@headlessui-react/src/components/listbox/listbox.tsx | 9 ++++++--- packages/@headlessui-react/src/components/menu/menu.tsx | 8 ++------ 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/packages/@headlessui-react/src/components/listbox/listbox.tsx b/packages/@headlessui-react/src/components/listbox/listbox.tsx index a4be69a..75e535d 100644 --- a/packages/@headlessui-react/src/components/listbox/listbox.tsx +++ b/packages/@headlessui-react/src/components/listbox/listbox.tsx @@ -144,7 +144,12 @@ type ListboxRenderPropArg = { open: boolean } export function Listbox< TTag extends React.ElementType = typeof DEFAULT_LISTBOX_TAG, TType = string ->(props: Props & { value: TType; onChange(value: TType): void }) { +>( + props: Props & { + value: TType + onChange(value: TType): void + } +) { const { value, onChange, ...passThroughProps } = props const d = useDisposables() const reducerBag = React.useReducer(stateReducer, { @@ -200,7 +205,6 @@ export function Listbox< const DEFAULT_BUTTON_TAG = 'button' type ButtonRenderPropArg = { open: boolean } type ButtonPropsWeControl = - | 'ref' | 'id' | 'type' | 'aria-haspopup' @@ -326,7 +330,6 @@ type OptionsPropsWeControl = | 'aria-labelledby' | 'id' | 'onKeyDown' - | 'ref' | 'role' | 'tabIndex' diff --git a/packages/@headlessui-react/src/components/menu/menu.tsx b/packages/@headlessui-react/src/components/menu/menu.tsx index b7d186a..f597a28 100644 --- a/packages/@headlessui-react/src/components/menu/menu.tsx +++ b/packages/@headlessui-react/src/components/menu/menu.tsx @@ -137,7 +137,6 @@ type MenuRenderPropArg = { open: boolean } export function Menu( props: Props ) { - const d = useDisposables() const reducerBag = React.useReducer(stateReducer, { menuState: MenuStates.Closed, buttonRef: React.createRef(), @@ -163,7 +162,7 @@ export function Menu( window.addEventListener('click', handler) return () => window.removeEventListener('click', handler) - }, [menuState, itemsRef, buttonRef, d, dispatch]) + }, [menuState, itemsRef, buttonRef, dispatch]) const propsBag = React.useMemo(() => ({ open: menuState === MenuStates.Open }), [menuState]) @@ -179,7 +178,6 @@ export function Menu( const DEFAULT_BUTTON_TAG = 'button' type ButtonRenderPropArg = { open: boolean } type ButtonPropsWeControl = - | 'ref' | 'id' | 'type' | 'aria-haspopup' @@ -269,7 +267,6 @@ type ItemsPropsWeControl = | 'aria-labelledby' | 'id' | 'onKeyDown' - | 'ref' | 'role' | 'tabIndex' @@ -395,7 +392,6 @@ function Item( ) { const { disabled = false, className, onClick, ...passthroughProps } = props const [state, dispatch] = useMenuContext([Menu.name, Item.name].join('.')) - const d = useDisposables() const id = `headlessui-menu-item-${useId()}` const active = state.activeItemIndex !== null ? state.items[state.activeItemIndex].id === id : false @@ -422,7 +418,7 @@ function Item( disposables().nextFrame(() => state.buttonRef.current?.focus()) if (onClick) return onClick(event) }, - [d, dispatch, state.buttonRef, disabled, onClick] + [dispatch, state.buttonRef, disabled, onClick] ) const handleFocus = React.useCallback(() => {