From 872808c8fcf3f9c0a2ec6d73174a98ed1765ceb9 Mon Sep 17 00:00:00 2001 From: Robin Malfait Date: Mon, 29 Apr 2024 20:28:22 +0200 Subject: [PATCH] ensure we always set `portal` to true when the `anchor` props is truthy We already had this for most components, but I missed it for this component. This fixes that. --- .../@headlessui-react/src/components/combobox/combobox.tsx | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/@headlessui-react/src/components/combobox/combobox.tsx b/packages/@headlessui-react/src/components/combobox/combobox.tsx index 8b68ced..479f2e2 100644 --- a/packages/@headlessui-react/src/components/combobox/combobox.tsx +++ b/packages/@headlessui-react/src/components/combobox/combobox.tsx @@ -1576,6 +1576,11 @@ function OptionsFn( let actions = useActions('Combobox.Options') let anchor = useResolvedAnchor(rawAnchor) + // Always enable `portal` functionality, when `anchor` is enabled + if (anchor) { + portal = true + } + let [floatingRef, style] = useFloatingPanel(anchor) let getFloatingPanelProps = useFloatingPanelProps() let optionsRef = useSyncRefs(data.optionsRef, ref, anchor ? floatingRef : null)