From 78776322995942375aaae48da13fe91ed9bb4b6f Mon Sep 17 00:00:00 2001 From: Robin Malfait Date: Tue, 29 Sep 2020 15:52:54 +0200 Subject: [PATCH] mark fallthrough as expected --- packages/@headlessui-react/src/components/menu/menu.tsx | 1 + packages/@headlessui-vue/src/components/menu/menu.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/@headlessui-react/src/components/menu/menu.tsx b/packages/@headlessui-react/src/components/menu/menu.tsx index 5949bc3..772a46c 100644 --- a/packages/@headlessui-react/src/components/menu/menu.tsx +++ b/packages/@headlessui-react/src/components/menu/menu.tsx @@ -397,6 +397,7 @@ const Items = forwardRefWithAs(function Items< switch (event.key) { // Ref: https://www.w3.org/TR/wai-aria-practices-1.2/#keyboard-interaction-12 + // @ts-expect-error Falthrough is expected here case Key.Space: if (state.searchQuery !== '') return dispatch({ type: ActionTypes.Search, value: event.key }) diff --git a/packages/@headlessui-vue/src/components/menu/menu.ts b/packages/@headlessui-vue/src/components/menu/menu.ts index 950924f..3337bbe 100644 --- a/packages/@headlessui-vue/src/components/menu/menu.ts +++ b/packages/@headlessui-vue/src/components/menu/menu.ts @@ -335,6 +335,7 @@ export const MenuItems = defineComponent({ switch (event.key) { // Ref: https://www.w3.org/TR/wai-aria-practices-1.2/#keyboard-interaction-12 + // @ts-expect-error Falthrough is expected here case Key.Space: if (api.searchQuery.value !== '') return api.search(event.key) // When in type ahead mode, fallthrough