From 415fca4383c2665d8aec91f2724472f44f18ebe7 Mon Sep 17 00:00:00 2001 From: Kristaps Fabians Geikins Date: Fri, 20 Jun 2025 17:22:32 +0300 Subject: [PATCH] fix: skip deleting portal root node to avoid race condition --- .../@headlessui-vue/src/components/portal/portal.ts | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/packages/@headlessui-vue/src/components/portal/portal.ts b/packages/@headlessui-vue/src/components/portal/portal.ts index 4f93573..6d3bfe3 100644 --- a/packages/@headlessui-vue/src/components/portal/portal.ts +++ b/packages/@headlessui-vue/src/components/portal/portal.ts @@ -1,6 +1,5 @@ import { Teleport, - computed, defineComponent, getCurrentInstance, h, @@ -51,7 +50,6 @@ export let Portal = defineComponent({ }, setup(props, { slots, attrs }) { let element = ref(null) - let ownerDocument = computed(() => getOwnerDocument(element)) let forcePortalRoot = usePortalRoot() let groupContext = inject(PortalGroupContext, null) @@ -90,16 +88,6 @@ export let Portal = defineComponent({ didRegister = true }) - onUnmounted(() => { - let root = ownerDocument.value?.getElementById('headlessui-portal-root') - if (!root) return - if (myTarget.value !== root) return - - if (myTarget.value.children.length <= 0) { - myTarget.value.parentElement?.removeChild(myTarget.value) - } - }) - return () => { if (!ready.value) return null if (myTarget.value === null) return null