From 8f91b3414f3c713d36bd7674596dc1c0a853cb19 Mon Sep 17 00:00:00 2001 From: "James Truher [MSFT]" Date: Thu, 9 Sep 2021 12:39:03 -0700 Subject: [PATCH] Be sure to open the hitfile with read access. (#1214) Be sure to open the hitfile with read access. --- src/coverlet.core/Coverage.cs | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/coverlet.core/Coverage.cs b/src/coverlet.core/Coverage.cs index b296eba..07e0612 100644 --- a/src/coverlet.core/Coverage.cs +++ b/src/coverlet.core/Coverage.cs @@ -408,7 +408,7 @@ namespace Coverlet.Core } var documentsList = result.Documents.Values.ToList(); - using (var fs = _fileSystem.NewFileStream(result.HitsFilePath, FileMode.Open)) + using (var fs = _fileSystem.NewFileStream(result.HitsFilePath, FileMode.Open, FileAccess.Read)) using (var br = new BinaryReader(fs)) { int hitCandidatesCount = br.ReadInt32(); @@ -442,8 +442,15 @@ namespace Coverlet.Core } } - _instrumentationHelper.DeleteHitsFile(result.HitsFilePath); - _logger.LogVerbose($"Hit file '{result.HitsFilePath}' deleted"); + try + { + _instrumentationHelper.DeleteHitsFile(result.HitsFilePath); + _logger.LogVerbose($"Hit file '{result.HitsFilePath}' deleted"); + } + catch (Exception ex) + { + _logger.LogWarning($"Unable to remove hit file: {result.HitsFilePath} because : {ex.Message}"); + } } }