review feedback

This commit is contained in:
Adam Hathcock
2024-05-22 08:34:43 +01:00
parent 95b5b15cb5
commit bdff84b9aa
9 changed files with 35 additions and 18 deletions
@@ -93,12 +93,12 @@ internal static class AttributeArgumentListParser
return false;
}
private static bool TryParseAsStringArray(ExpressionSyntax expressionSyntax, out string[] value)
private static bool TryParseAsStringArray(ExpressionSyntax expressionSyntax, [NotNullWhen(true)] out string[] value)
{
if (expressionSyntax is ImplicitArrayCreationExpressionSyntax lmplicitArrayCreationExpressionSyntax)
if (expressionSyntax is ImplicitArrayCreationExpressionSyntax implicitArrayCreationExpressionSyntax)
{
var strings = new List<string>();
foreach (var expression in lmplicitArrayCreationExpressionSyntax.Initializer.Expressions)
foreach (var expression in implicitArrayCreationExpressionSyntax.Initializer.Expressions)
{
if (expression.GetFirstToken().Value is string s)
{
@@ -108,7 +108,8 @@ internal static class AttributeArgumentListParser
value = strings.ToArray();
return true;
}
value = Array.Empty<string>();
value = default;
return false;
}
}